-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[many ports] Include functional to fix error C2039 and C2504 #30946
[many ports] Include functional to fix error C2039 and C2504 #30946
Conversation
maybe patch the use of these functions out since they have been deprecated since c++11 and are removed in 17 (Maybe there is an update upstream which already does this?) |
…lyWangLL/vcpkg into dev/LilyWang/CI_Unstable_0417
I think that crosses into 'upstream needs to be in the loop' territory where just add standard library header can be considered 'fairly mindless'. |
Tagging vcpkg-team-review for the 'rename upstream targets' question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @dg0yt has pointed out a legitimate problem with the edits to libsbml. It might be a good idea to separate that into its own PR since it is very much not "include functional" like the other changes here.
Thanks!
Done. I reverted the changes of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
In an internal version of Visual Studio, many ports install failed with following error:
Or
The reason is new STL change, need include
<functional>
to fix them.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.I have submitted an issue on upstream:
kpu/kenlm#428
themoos/core-moos#71